-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 'cardano-wallet-launcher' & 'cardano-wallet' together #414
Conversation
--state <STRING> address state: either used or unused | ||
--state-dir <DIR> write wallet state (blockchain and database) to this directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sorted all the options alphabetically.
out `shouldContain` "cardano-wallet-launcher" | ||
c `shouldBe` ExitSuccess | ||
forM_ ["-h", "--help"] test | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same tests already exist for cardano-wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm based on a moderately quick look
ff4368e
to
94623f8
Compare
94623f8
to
840fa20
Compare
3af8dba
to
14589c9
Compare
There's a non-significant cost with the use of 'fixtureWallet' since it needs to restore a funded wallet and wait until restoration. We also only have a limited number of those wallets, so it's better to keep them for when we actually really need funded wallets. When testing parsing errors or wrong headers, there's no need for demanding a wallet with funds
And right now, it's making the test fail because we do need a funded wallet to make this test. So it'll be best to re-introduce it as part of a separate scenario, that we only run for the bridge
This takes the cardano-sl/cardano-shell NodeIPC code and splits the general nodejs child_process IPC protocol out from the Daedalus/Cardano specific protocol, improves the exception handling, changes the logging, and just makes it simpler.
Removing a type constructor can change the shape of the JSON.
14589c9
to
725c822
Compare
Issue Number
#368
Overview
cardano-wallet-launcher
used to do.cardano-wallet launch
cardano-wallet server
tocardano-wallet serve
as discussed briefly on slack--port
and--random-port
options for thelaunch
commandComments